Improve devcontainer experience #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykut-bozkurt
force-pushed
the
aykut/devcontainer
branch
7 times, most recently
from
0e368ae
to
e68d7a0
Compare
- [x] Switch to `docker-compose.yml` instead of `Dockerfile` for dev container setup, - [x] Sets up minio s3 emulator via docker container, - [x] Add `CONTRIBUTING.md`.
aykut-bozkurt
force-pushed
the
aykut/devcontainer
branch
from
e68d7a0
to
e4e20da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-compose.ymlinstead ofDockerfilefor dev container setup,dotenvycrate dependency as we export env vars from .env file both at ci and dev container,CONTRIBUTING.md.NOTE: for macOS users that have unexpected permission errors, you can switch from
virtiofsintogRPC fusecontainer file sharing implementation. There are sometimes issues with permissions with virtiofs. (see issue docker/for-mac#6614 (comment))Closes #58