Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccp_is_in_recovery_status: Metric description mistake #375

Closed
Mmefko opened this issue Oct 10, 2023 · 2 comments · Fixed by #376
Closed

ccp_is_in_recovery_status: Metric description mistake #375

Mmefko opened this issue Oct 10, 2023 · 2 comments · Fixed by #376
Assignees
Labels
DOCS Documentation Issue VALID Valid issue. Will be assigned and worked

Comments

@Mmefko
Copy link

Mmefko commented Oct 10, 2023

ccp_is_in_recovery_status. It looks like the description in the documentation contains a mistake.

Current description: ccp_is_in_recovery_status - Current value of the pg_is_in_recovery() function expressed as 2 for true (instance is a replica) and 1 for false (instance is a primary)

  • 2 - replica
  • 1 - primary

And on the other side - query:

ccp_is_in_recovery:
        query: "SELECT CASE WHEN pg_is_in_recovery = true THEN 1 ELSE 2 END AS status from pg_is_in_recovery();"
        metrics:
          - status:
  • 1 - replica
  • 2 - primary

Expected behavior: Correct description of the metric

  • ccp_is_in_recovery_status - Current value of the pg_is_in_recovery() function expressed as 1 for true (instance is a replica) and 2 for false (instance is a primary)
@Mmefko Mmefko added the UNCONFIRMED Initial state. Need's triaged label Oct 10, 2023
@keithf4
Copy link
Collaborator

keithf4 commented Oct 10, 2023

Thank you for pointing this out! Will get a PR up shortly with a fix

@keithf4 keithf4 added VALID Valid issue. Will be assigned and worked DOCS Documentation Issue and removed UNCONFIRMED Initial state. Need's triaged labels Oct 10, 2023
@keithf4 keithf4 self-assigned this Oct 10, 2023
@keithf4
Copy link
Collaborator

keithf4 commented Oct 23, 2023

We've merged a fix for this into the documentation. We'll work on getting that pushed out to our docs site as soon as possible.

Thank you for the notification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOCS Documentation Issue VALID Valid issue. Will be assigned and worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants