Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix recovery metric values in documentation #376

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

keithf4
Copy link
Collaborator

@keithf4 keithf4 commented Oct 10, 2023

Description

Fix the recovery metric values in the documentation to be accurate.

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #375

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s): 0.80.0

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • SLES
  • Not applicable

If your code touches postgres_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4 keithf4 added the DOCS Documentation Issue label Oct 10, 2023
@keithf4 keithf4 added this to the Future milestone Oct 10, 2023
@keithf4 keithf4 self-assigned this Oct 10, 2023
pgguru
pgguru previously approved these changes Oct 10, 2023
Copy link
Collaborator

@hunleyd hunleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing fragment?

(the workflow didn't run to catch it)

@keithf4
Copy link
Collaborator Author

keithf4 commented Oct 11, 2023

missing fragment?

(the workflow didn't run to catch it)

missing fragment?

(the workflow didn't run to catch it)

Fixed. Any idea why it didn't run?

@keithf4 keithf4 requested review from pgguru and hunleyd October 11, 2023 13:12
@hunleyd hunleyd mentioned this pull request Oct 11, 2023
@keithf4 keithf4 merged commit 476d3be into CrunchyData:development Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOCS Documentation Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccp_is_in_recovery_status: Metric description mistake
4 participants