Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sql_exporter with pgMonitor extension #361

Merged
merged 33 commits into from
Apr 24, 2024

Conversation

keithf4
Copy link
Collaborator

@keithf4 keithf4 commented Aug 29, 2023

Description

The adds support for the sql_exporter which makes use of the new extension metrics. It requires the pgmonitor-extension found here - https://github.com/CrunchyData/pgmonitor-extension

The extension adds features for

  • materialized views for more complicated queries or queries that may run slower (Ex. size)
    • Additional metrics to monitor if refresh ran and for how long
  • plain views to define other metrics that need immediate, matview results (replication, connections, etc)
  • refreshing of a plain table for more complicated metrics that cannot use a matview (pgbackrest monitoring)

Other new features in 5.0 include

  • Add support for collecting metrics directly from PgBouncer instead of requiring the pgbouncer_fdw.
  • New Grafana dashboards to support sql_exporter and direct pgBouncer monitoring (instead of using pgbouncer_fdw)
  • Add support for alerting on pgmonitor-extension runtime metrics
  • Reorganize the Grafana dashboards in the repository to make it easier to individually package the different types of dashboards and only install the ones that are actually in use

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #395

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

depends on #

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s): All supported (11-15)
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • SLES
  • Not applicable

If your code touches postgres_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4 keithf4 added the FEATURE New feature or request label Aug 29, 2023
@keithf4 keithf4 added this to the 5.0 milestone Aug 29, 2023
@keithf4 keithf4 self-assigned this Aug 29, 2023
@ChuckHend
Copy link

👋

@keithf4 keithf4 changed the base branch from development to v5.0-dev February 14, 2024 18:49
@keithf4 keithf4 marked this pull request as ready for review April 4, 2024 21:14
@keithf4 keithf4 changed the base branch from v5.0-dev to development April 8, 2024 14:12
hugo/content/exporter/_index.md Outdated Show resolved Hide resolved
hugo/content/exporter/_index.md Outdated Show resolved Hide resolved
hugo/content/exporter/_index.md Outdated Show resolved Hide resolved
hugo/content/exporter/_index.md Outdated Show resolved Hide resolved
hugo/content/exporter/_index.md Outdated Show resolved Hide resolved
hugo/content/exporter/_index.md Outdated Show resolved Hide resolved
hugo/content/exporter/_index.md Outdated Show resolved Hide resolved
hugo/content/exporter/_index.md Outdated Show resolved Hide resolved
hugo/content/grafana/_index.md Outdated Show resolved Hide resolved
sql_exporter/linux/crunchy-sql-exporter@.service Outdated Show resolved Hide resolved
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
@keithf4 keithf4 requested a review from hunleyd April 12, 2024 18:49
hunleyd
hunleyd previously approved these changes Apr 15, 2024
@keithf4 keithf4 requested a review from hunleyd April 17, 2024 21:01
changelogs/fragments/361.yml Outdated Show resolved Hide resolved
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
@keithf4 keithf4 requested a review from hunleyd April 19, 2024 18:38
hunleyd
hunleyd previously approved these changes Apr 22, 2024
Copy link
Contributor

@jchancojr jchancojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keithf4 keithf4 merged commit e11f5e3 into CrunchyData:development Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to sql_exporter
4 participants