-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for sql_exporter with pgMonitor extension #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithf4
commented
Sep 5, 2023
👋 |
…tter define new extras package
hunleyd
requested changes
Apr 9, 2024
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
hunleyd
previously approved these changes
Apr 15, 2024
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
hunleyd
requested changes
Apr 18, 2024
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
hunleyd
previously approved these changes
Apr 22, 2024
hunleyd
approved these changes
Apr 24, 2024
jchancojr
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The adds support for the sql_exporter which makes use of the new extension metrics. It requires the pgmonitor-extension found here - https://github.com/CrunchyData/pgmonitor-extension
The extension adds features for
Other new features in 5.0 include
Please indicate what kind of change your PR includes (multiple selections are acceptable):
PRs should be against existing issues, so please list each issue using a separate 'closes' line:
closes #395
If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.
depends on #
If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.
Testing
None of the testing listed below is optional.
Code testing
Have you tested your changes against:
If your code touches postgres_exporter, have you:
If your code touches node_exporter, have you:
If your code touches Prometheus, have you:
promtool check config
promtool check rules
If your code touches Grafana, have you:
Checklist: