-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: update dependencies for monitoring services #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithf4
changed the title
feature: update dependencies for node_exporter 1.5+
feature: update dependencies for monitoring services
Nov 1, 2023
hunleyd
requested changes
Nov 2, 2023
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
pgguru
previously approved these changes
Nov 2, 2023
hunleyd
previously approved these changes
Nov 3, 2023
hunleyd
approved these changes
Nov 6, 2023
jchancojr
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pgguru
approved these changes
Nov 6, 2023
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update build dependencies to the following
Please indicate what kind of change your PR includes (multiple selections are acceptable):
PRs should be against existing issues, so please list each issue using a separate 'closes' line:
closes #378
Testing
None of the testing listed below is optional.
Code testing
Have you tested your changes against:
If your code touches postgres_exporter, have you:
If your code touches node_exporter, have you:
If your code touches Prometheus, have you:
promtool check config
promtool check rules
If your code touches Grafana, have you:
Checklist: