Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix pgbackrest script to use proper console log level #402

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

keithf4
Copy link
Collaborator

@keithf4 keithf4 commented Apr 17, 2024

Description

Fix the pgbackrest-info.sh script to force the info console log level so that it gets the expected output format no matter what log level the user may have in the backrest config

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #401

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

depends on #

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • SLES
  • Not applicable

If your code touches postgres_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

hunleyd
hunleyd previously approved these changes Apr 18, 2024
jchancojr
jchancojr previously approved these changes Apr 18, 2024
YorviArias
YorviArias previously approved these changes Apr 18, 2024
@keithf4 keithf4 dismissed stale reviews from YorviArias, jchancojr, and hunleyd via 9e57816 April 19, 2024 21:32
hunleyd
hunleyd previously approved these changes Apr 22, 2024
jchancojr
jchancojr previously approved these changes Apr 23, 2024
@keithf4 keithf4 dismissed stale reviews from jchancojr and hunleyd via 417870f April 24, 2024 13:26
@keithf4 keithf4 requested review from hunleyd and jchancojr April 24, 2024 13:28
@keithf4 keithf4 merged commit 0a3a766 into CrunchyData:development Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgbackrest-info.sh expectations on --log-level-console
4 participants