Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Portal Frame? #11

Closed
1 task done
Dumpling00 opened this issue Jul 28, 2024 · 10 comments
Closed
1 task done

Custom Portal Frame? #11

Dumpling00 opened this issue Jul 28, 2024 · 10 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Dumpling00
Copy link

I have confirmed no other issue asks the same question

  • I have searched for existing issues

Question

Hello! Big fan of the mod. I was wondering if there's any way we could change the type of block needed for the portal frame via datapack, please.

Additional context

No response

@Dumpling00 Dumpling00 added medium priority Needs to be worked on question Further information is requested labels Jul 28, 2024
@Crystal-Spider Crystal-Spider added documentation Improvements or additions to documentation enhancement New feature or request high priority Needs to be worked on ASAP and removed question Further information is requested medium priority Needs to be worked on labels Aug 3, 2024
@Crystal-Spider
Copy link
Member

Crystal-Spider commented Aug 3, 2024

We will add a new block tag, and then check for the portal frame will be done using that block tag.

By default, the block tag will include Vanilla Crying Obsidian only.

We will also update the mod info (just the readme I guess) to highlight this functionality.

Copy link

This issue is stale because it has been open for 14 days with no activity. In 14 days it is going to be closed.

@github-actions github-actions bot added the stale Inactive for a long while label Aug 18, 2024
@Crystal-Spider Crystal-Spider removed the stale Inactive for a long while label Aug 18, 2024
@Crystal-Spider
Copy link
Member

The feature has been implemented, but has been moved to a different mod that works as an API to add any custom dimension and portal frame, while working server side, with just the dimension JSONs and the block tag for the portal frame.

We are currently on vacation, but in around 1 week we'll be back to work! Please, be patient until then!

Copy link

github-actions bot commented Sep 2, 2024

This issue is stale because it has been open for 14 days with no activity. In 14 days it is going to be closed.

@github-actions github-actions bot added the stale Inactive for a long while label Sep 2, 2024
@Crystal-Spider Crystal-Spider removed the stale Inactive for a long while label Sep 2, 2024
@Crystal-Spider
Copy link
Member

The other mod is ready for 1.21, we need to backport it to older versions too, and then we can release it along with a new Nightworld version that uses it.
It should be ready either by this weekend or the next one

@Dumpling00
Copy link
Author

Awesome! Thank you so much ❤️

@Dumpling00
Copy link
Author

Dumpling00 commented Sep 6, 2024

Bit last minute actually (I apologize) But any chance we could change the igniter item and portal color too?

@Crystal-Spider
Copy link
Member

Unfortunately, since this mod is server side only, it's not possible to change the color, which is be a client sided feature.
Using an item tag to tweak which items ignite the portal is theoretically possible, but due to the use of Vanilla Nether portals (which is mandatory to make this mod server-sided only) it's not actually feasible because Nether portals leverage on fire rather than the item.

@Crystal-Spider
Copy link
Member

The other mod is currently under review on Modrinth, as soon as it'll be available there I will release Nightworld new versions using it and that allow tweaking of the portal frame block via datapack.

To change the portal frame block you'll simply have to create a datapack and put, under the server_sided_portals namespace, a block tag called nightworld.json and list the block(s) you want the portal frame to be made of.

@Crystal-Spider
Copy link
Member

Implemented with v4.0.0

@github-actions github-actions bot removed the high priority Needs to be worked on ASAP label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants