Prometheus data exporting #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
fd219be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27cd9861.cubic-server.pages.dev |
| Branch Preview URL: | https://analytics-exporting.cubic-server.pages.dev |
added 3 commits
November 4, 2023 19:14
It is really basic and it will throw really bad errors sometimes but for now this is already worth committing
If only I had known about this earlier ;w;
emneo-dev
force-pushed
the
analytics-exporting
branch
from
ad46fc8
to
6831719
Compare
added 3 commits
November 9, 2023 14:23
There was a slight mismatch between the forward declaration and the actual type, which clang said could cause link errors on Windows.
It is global and dimensions based. There's also version info in the export now.
|
Some ideas of data to export:
|
STMiki
previously approved these changes
Nov 9, 2023
cubic-server/Server.cpp
Outdated
| @@ -165,32 +156,20 @@ void Server::launch(const configuration::ConfigHandler &config) | |||
|
|
|||
| _writeThread = std::thread(&Server::_writeLoop, this); | |||
|
|
|||
| #if PROMETHEUS_SUPPORT == 1 | |||
| if (CONFIG["monitoring-prometheus-enable"].as<bool>()) { | |||
| _prometheusExporter = std::make_unique<PrometheusExporter>("0.0.0.0:4242"); | |||
There was a problem hiding this comment.
Is this really the default port for prometheus ? :')
There was a problem hiding this comment.
Can it be 8080 by default?
There was a problem hiding this comment.
Bruh I forgot to make it a config xd
There was a problem hiding this comment.
Lemme fix that real quick
|
|
STMiki
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.