Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/components creation #1

Merged
merged 7 commits into from
Jul 6, 2021
Merged

Feature/components creation #1

merged 7 commits into from
Jul 6, 2021

Conversation

DorAbu
Copy link
Contributor

@DorAbu DorAbu commented May 16, 2021

No description provided.

DavidMeu
DavidMeu reviewed May 20, 2021
View reviewed changes
.gitignore Show resolved Hide resolved
@DorAbu DorAbu closed this Jun 22, 2021
@DorAbu DorAbu reopened this Jun 22, 2021
@DorAbu DorAbu marked this pull request as ready for review June 22, 2021 15:15
DavidMeu
DavidMeu reviewed Jun 22, 2021
View reviewed changes
.flake8 Show resolved Hide resolved
DavidMeu
DavidMeu reviewed Jun 23, 2021
View reviewed changes
codemate/block.py Outdated Show resolved Hide resolved
DavidMeu
DavidMeu reviewed Jun 23, 2021
View reviewed changes
codemate/utils.py Outdated Show resolved Hide resolved
DavidMeu
DavidMeu reviewed Jun 23, 2021
View reviewed changes
codemate/block.py Outdated Show resolved Hide resolved
DavidMeu
DavidMeu reviewed Jun 23, 2021
View reviewed changes
codemate/block.py Outdated Show resolved Hide resolved
DavidMeu
DavidMeu reviewed Jun 23, 2021
View reviewed changes
tests/utils.py Outdated Show resolved Hide resolved
DavidMeu
DavidMeu suggested changes Jun 23, 2021
View reviewed changes
Copy link

@DavidMeu DavidMeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Placed some comments.

@DavidMeu DavidMeu self-requested a review July 6, 2021 07:27
DavidMeu
DavidMeu approved these changes Jul 6, 2021
View reviewed changes
Copy link

@DavidMeu DavidMeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code!
👍🏽

@DorAbu DorAbu merged commit 46b0eaf into main Jul 6, 2021
@DorAbu DorAbu deleted the feature/components-creation branch July 6, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMeu DavidMeu DavidMeu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DorAbu @DavidMeu @dor-abu