Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Vulnerability objects comparable by value #464

Conversation

SaberStrat
Copy link

Enables comparison of two Vulnerability objects by their fields' values.

Implements #463

@SaberStrat SaberStrat marked this pull request as ready for review July 28, 2024 06:42
@SaberStrat SaberStrat requested a review from a team as a code owner July 28, 2024 06:42
@nscuro
Copy link
Member

nscuro commented Aug 1, 2024

@SaberStrat FYI the build failures should be fixed by #469, I am currently waiting for a review on that. Once merged, you can rebase your branch and the build will work.

@nscuro nscuro added the enhancement New feature or request label Aug 1, 2024
@VinodAnandan
Copy link

@SaberStrat thank you for your PR. The #469 PR has been merged. Could you please rebase your PR?

Enables comparison of two Vulnerability objects by their field values.

Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
@SaberStrat SaberStrat force-pushed the feature/463-make-vulnerability-objects-comparable-by-fields branch from 4add0b1 to 8b67e69 Compare August 6, 2024 05:16
@SaberStrat
Copy link
Author

Rebased for #469

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.89% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (31c2226) 5956 4400 73.88%
Head commit (8b67e69) 6029 (+73) 4400 (+0) 72.98% (-0.89%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#464) 73 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit b7b99fa into CycloneDX:master Aug 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants