Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend EvidenceOccurrence #156

Closed
mcombuechen opened this issue May 8, 2024 · 1 comment
Closed

Extend EvidenceOccurrence #156

mcombuechen opened this issue May 8, 2024 · 1 comment
Labels
enhancement New feature or request spec/1.6

Comments

@mcombuechen
Copy link
Contributor

Type EvidenceOccurrence has been extended with new properties in spec 1.6.

  • lineNumber
  • offset
  • symbol
  • additionalContext

Resources:

When adding these new properties to type EvidenceOccurrence, consider the conversion code for components in convert.go to achieve backwards compatibility with spec versions < v1.6.
@nscuro nscuro added enhancement New feature or request spec/1.6 labels May 8, 2024
mcombuechen added a commit to mcombuechen/cyclonedx-go that referenced this issue May 9, 2024
@mcombuechen
feat(1.6): extend EvidenceOccurrence
c5fe752 
Closes CycloneDX#156.

Signed-off-by: Maximilian Combüchen <max.combuchen@snyk.io>
@mcombuechen mcombuechen mentioned this issue May 9, 2024
Merged
mcombuechen added a commit to mcombuechen/cyclonedx-go that referenced this issue May 12, 2024
@mcombuechen
feat(1.6): extend EvidenceOccurrence
501c5ef 
Closes CycloneDX#156.

Signed-off-by: Maximilian Combüchen <max.combuchen@snyk.io>
mcombuechen added a commit to mcombuechen/cyclonedx-go that referenced this issue May 13, 2024
@mcombuechen
feat(1.6): extend EvidenceOccurrence
b1636c2 
Closes CycloneDX#156.

Signed-off-by: Maximilian Combüchen <max.combuchen@snyk.io>
@nscuro
Copy link
Member

nscuro commented May 29, 2024

Implemented in #159

@nscuro nscuro closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request spec/1.6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcombuechen @nscuro