-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support CBOM (1.6 specification) (#140) #142
Closed
Closed
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d98494e
build(deps): bump gitpod/workspace-go from `9118b93` to `8b9a0f6`
dependabot[bot] e8a52d8
Feat(CBOM Types): Added CBOM types
Petzys f13799c
Feat(spec type): Added v1.6 spec type
Petzys eb5f576
Fix(CBOM Types): Removed omitempty where zero values are needed
Petzys 988f215
Fix(CBOM Types): Added "Crypto" prefix to generic sounding types
Petzys ec6291e
build(deps): bump actions/checkout from 4.1.1 to 4.1.5
dependabot[bot] 521d1ce
build(deps): bump golangci/golangci-lint-action from 4.0.0 to 6.0.1
dependabot[bot] c6f99a0
Merge pull request #150 from CycloneDX/dependabot/github_actions/gola…
nscuro 062472d
Merge pull request #148 from CycloneDX/dependabot/github_actions/acti…
nscuro b9ef26c
Merge pull request #136 from CycloneDX/dependabot/docker/gitpod/works…
nscuro 8674ed5
build(deps): bump actions/setup-go from 5.0.0 to 5.0.1
dependabot[bot] 82bc972
Merge pull request #146 from CycloneDX/dependabot/github_actions/acti…
nscuro 2499ef8
Merge branch 'CycloneDX:master' into master
mcombuechen ff41376
fix: reorder, adjust types
mcombuechen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these types have rather generic names (e.g.
Primitive
,Mode
). We need to pay attention that we won't cause naming collisions as the spec grows. Consider prefixing some of these types so they're "pseudo-namespaced". For exampleCryptoPrimitive
instead ofPrimitive
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I see your point and I agree. I think
Crypto
works as a prefix. I will work on that.