Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GOOS and GOARCH into PURL #217

Merged
merged 4 commits into from
Dec 12, 2022
Merged

feat: add GOOS and GOARCH into PURL #217

merged 4 commits into from
Dec 12, 2022

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Nov 22, 2022 

- keep bom-ref as is
- only metadata.component.purl and components.component.purl are updated

Ref: #148

@zdtsw zdtsw requested a review from a team as a code owner November 22, 2022 12:26
@zdtsw
feat: add os and arch into PURL
f2dd2ca 
	- keep bom-ref as is
	- only metadata.component.purl and components.component.purl are updated

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
nscuro
nscuro requested changes Nov 22, 2022
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @zdtsw! 🙌

We'll need a different way of pulling in the GOOS and GOARCH info. I've made a suggestion, but am open to any alternatives you may have!

internal/gomod/module.go Outdated Show resolved Hide resolved
@zdtsw
update: change to use gocmd to get GOOS and GOARCH from "go env -json"
5f81bf7 
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw
test: update testdata
981479c 
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw
style: gofmt and use logger NoP()
732ff78 
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
nscuro
nscuro approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zdtsw!

Sorry for the long wait 😅

@nscuro nscuro merged commit 86d7a92 into CycloneDX:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdtsw @nscuro