Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable override of the default component name #467

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

MH-17
Copy link

@MH-17 MH-17 commented Jul 22, 2024

Proposal for #466

@MH-17 MH-17 requested a review from a team as a code owner July 22, 2024 12:50
Signed-off-by: Martin Holfelder <Martin.Holfelder@tgw-group.com>
Copy link
Contributor

@skhokhlov skhokhlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test to verify that the current behaviour is still there if the property is not set? We will merge it after it.

Signed-off-by: Martin Holfelder <Martin.Holfelder@tgw-group.com>
Copy link
Contributor

@skhokhlov skhokhlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

@skhokhlov skhokhlov merged commit 0d0781c into CycloneDX:master Jul 25, 2024
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable override of the default component name Issues using custom archive names with a multi-project setup
2 participants