-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cdx:maven
for Maven ecosystem taxonomy
#107
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: skhokhlov <me@skhlv.nyc>
cdx:maven
for Maven ecosystem taxonomy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case the docs are intended to document taxonomy that is already used, I have nothing to add.
In case the taxonomy is still in planning phase, I've added some remarks
| Property | Description | | ||
|----------|-------------| | ||
| `cdx:maven:package:test` | Whether the package is used only within `test` scope for Maven and `test.*` configurations for Gradle. _Boolean value_. If the property is missing, then assume the value to be `false`. May appear once. | | ||
| `cdx:maven:package:projectsAndScopes` | Comma separated list of pairs of project and scope (configuration) names. In case if component is used in multiply scopes for a project, dedicated pair will be used for it. Example value: `project1:scopeA,project1:scopeB,project2:scopeA` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for comma separated. Better go with a multi-use.
Applied, it would be like
{
"properties": [
{ "name": "cdx:maven:package:projectsAndScope", "value":"project1:scopeA" },
{ "name": "cdx:maven:package:projectsAndScope", "value":"project1:scopeB" },
{ "name": "cdx:maven:package:projectsAndScope", "value":"project2:scopeA" },
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, multi-property way is better
@skhokhlov, are these properties used already? if not, i'd suggest a change - #107 (comment) |
These properties are not used yet in CycloneDX plugins. For |
Sorry, I do not understand. could you craft an example SBOM? |
Sure {
"bomFormat" : "CycloneDX",
"metadata" : {
"component" : {
"type" : "library",
"bom-ref" : "bom-ref-root-project-1",
"name": "root-project-1"
}
},
"components" : [
{
"type" : "library",
"bom-ref" : "bom-ref-sub-project-1",
"name": "sub-project-1",
"properties": [
{ "name": "cdx:maven:package:projectsAndScope", "value":"bom-ref-root-project-1:scopeA" },
{ "name": "cdx:maven:package:projectsAndScope", "value":"bom-ref-root-project-1:scopeB" }
]
},
{
"type" : "library",
"bom-ref" : "bom-ref-library-1",
"name": "library-1",
"properties": [
{ "name": "cdx:maven:package:projectsAndScope", "value":"bom-ref-sub-project-1:scopeA" },
{ "name": "cdx:maven:package:projectsAndScope", "value":"bom-ref-root-project-1:scopeB" }
]
}
],
"dependencies": [
{
"ref": "bom-ref-root-project-1",
"dependsOn": ["bom-ref-sub-project-1", "bom-ref-library-1"]
},
{
"ref": "bom-ref-sub-project-1",
"dependsOn": ["bom-ref-library-1"]
}
]
} Using So the question is should we use { "name": "cdx:maven:package:projectsAndScope", "value":"bom-ref-sub-project-1:scopeA" } instead of { "name": "cdx:maven:package:projectsAndScope", "value":"sub-project-1:scopeA" }, ? |
re: #107 (comment) I understand, but this seems debatable, especially with https://cyclonedx.org/capabilities/bomlink/ in mind. I'd suggest omitting The taxonomy can be extended and modified at any time. How does this sound to you? |
fixes #106