Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid ref in tools/src/test/resources/1.4/valid-vulnerability-1.4.json #127

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

damiencarol
Copy link
Contributor

@damiencarol damiencarol commented Jan 23, 2022

  1. The vulnerability use a reference to a component that is not in the BOM.
    Should be pkg:maven/com.fasterxml.jackson.core/jackson-databind@2.9.4
    instead of pkg:maven/com.fasterxml.jackson.core/jackson-databind@2.9.9
    Because the firs tone is in the bom-ref of a component in the BOM.

See tools/src/test/resources/1.4/valid-vulnerability-1.4.json

  1. the CVSS v3 vector is wrong (not well formed data)

It is "vector": "AN/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H", in the current file.
Should be "vector": "AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H",

Signed-off-by: damiencarol <damien.carol@gmail.com>
Signed-off-by: damiencarol <damien.carol@gmail.com>
@damiencarol damiencarol changed the base branch from master to v1.4-dev January 23, 2022 20:54
@damiencarol damiencarol changed the base branch from v1.4-dev to master January 23, 2022 20:55
@damiencarol
Copy link
Contributor Author

@jkowalleck ?

@stevespringett
Copy link
Member

Thanks for identifying and correcting our mistake. Much appreciated.

@stevespringett stevespringett merged commit acb644d into CycloneDX:master Jun 8, 2022
@damiencarol damiencarol deleted the patch-1 branch June 10, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants