-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added identity and occurrences to evidence. Updated test cases. #199
Conversation
Signed-off-by: Steve Springett <steve@springett.us>
@@ -19,6 +19,40 @@ | |||
], | |||
"purl": "pkg:maven/com.google.code.findbugs/findbugs-project@3.0.0", | |||
"evidence": { | |||
"identity": { | |||
"field": "purl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sold on the idea that this "field" needs to even be there. The original idea was to be able to separate out individual evidence of group/name/version into individual pieces of evidence. But for some things, it actually doesn't make sense (like purl).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same would apply fo "field" in the XML and protobuf.
"uniqueItems": true, | ||
"additionalItems": false, | ||
"items": { | ||
"$ref": "#/definitions/refType" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this is in line with #198
according to specification/schema/bom-1.5.schema.json Lines 1262 to 1268 in 56dfd3d
and specification/schema/bom-1.5.schema.json Lines 1299 to 1305 in 56dfd3d
We have an overall confidence, and we have multiple specific confidence values. Therefore, i would argue, that the weighing of each specific confidence value should be published. ❌ Therefore, Ii do not agree to the existence of such property. PS: here are examples: weights unknown
weights are equal - per definition
individual weights published
|
@jkowalleck Thanks for your input. Based on today's IWG meeting, it's my understanding that |
Per #129 (comment) callstack is being added in. Will update when complete. |
Signed-off-by: Steve Springett <steve@springett.us>
Ok, callstack support has been added back into this PR and test cases |
Signed-off-by: Steve Springett <steve@springett.us>
Closes #129