Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ML #209

Merged
merged 9 commits into from
May 12, 2023
Merged

Added support for ML #209

merged 9 commits into from
May 12, 2023

Conversation

stevespringett
Copy link
Member

@stevespringett stevespringett commented Apr 11, 2023

Closes #112

stevespringett and others added 7 commits February 22, 2023 12:03
Signed-off-by: Steve Springett <steve@springett.us>
Signed-off-by: Steve Springett <steve@springett.us>
Signed-off-by: Steve Springett <steve@springett.us>
Signed-off-by: Steve Springett <steve@springett.us>
…ON schema. Added test cases.

Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett stevespringett added this to the 1.5 milestone Apr 11, 2023
@stevespringett stevespringett self-assigned this Apr 11, 2023
@stevespringett stevespringett linked an issue Apr 11, 2023 that may be closed by this pull request
@stevespringett stevespringett added the RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration label Apr 11, 2023
@jkowalleck
Copy link
Member

jkowalleck commented Apr 14, 2023

❗ I see a lot of newly introduced "MUST", "MUST NOT" in XML documentations.
If there are such rules, then a xs:restriction is to be formulated, or else we would end up like SPDX where a lot of text describes the format, but nothing machine-readable makes this clear.

I'd recommend creating a followup-task that takes care of this, after this PR was merged.

@dasarpjonam
Copy link

@stevespringett - what is the best way to reference model versioning? In case data, the version information i assume would be in its BOM?

@stevespringett
Copy link
Member Author

what is the best way to reference model versioning? In case data, the version information i assume would be in its BOM?

That is correct @dasarpjonam. The ML component can have a version, and if the ML component refers to a data component, then the data component can have its own version independent of the ML component that uses it.

@stevespringett stevespringett merged commit 52104c3 into v1.5-dev May 12, 2023
@stevespringett stevespringett deleted the v1.5-dev-machine-learning branch May 12, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposed core enhancement request for comment RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration RFC vote accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ML models
3 participants