fix(xml): requirement descriptions should be unbounded #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes CycloneDX#528 where occurrences of definitions.standards.requirements.descriptions should be unbounded Signed-off-by: Hakan Dilek <hakandilek@gmail.com>
under definitions.standards, requirement may have - multiple descriptions and - a text field Signed-off-by: Hakan Dilek <hakandilek@gmail.com>
|
@jkowalleck This one is ready for a review including the tests mentioned before. |
jkowalleck
approved these changes
Nov 4, 2024
|
This one Java test is failing because it's referring to the prepacked schema file from within the released (v9.0.5) jar file: |
exactly. It is on my radar for a long while, to rework these java tests in a way they use the schema files in this repo, instead of some shipped ones in a library... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #528
where occurrences of
definitions.standards.requirements.descriptionsshould be unbounded