Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for key/value store (properties) #55

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Added support for key/value store (properties) #55

merged 2 commits into from
Apr 21, 2021

Conversation

stevespringett
Copy link
Member

This PR implements #42 for the BOM itself (metadata) and for an individual component and service.

@stevespringett
#42 - Added support for key/value store (properties) for BOM metadata…
8c3ab62 
…, and an individual component and service.
coderpatros
coderpatros approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@coderpatros coderpatros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just wondering if the tests should include multiple properties with the same key and different values? Just in case anyone (me) is using core spec tests for implementations :)

@coderpatros coderpatros added this to the 1.3 milestone Apr 20, 2021
@coderpatros coderpatros changed the base branch from master to v1.3 April 21, 2021 11:19
@coderpatros coderpatros merged commit 23e0f73 into v1.3 Apr 21, 2021
@coderpatros coderpatros deleted the key-value-properties branch April 21, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderpatros coderpatros coderpatros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@stevespringett @coderpatros