Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented release notes in XML, JSON, and Protobuf #88

Merged
merged 9 commits into from
Dec 20, 2021
Merged

Implemented release notes in XML, JSON, and Protobuf #88

merged 9 commits into from
Dec 20, 2021

Conversation

stevespringett
Copy link
Member

See #87

@stevespringett
Copy link
Member Author

stevespringett commented Oct 4, 2021 •
edited
Loading

  • TODO: Add doc enhancement for attachment text to describe proactive controls

@stevespringett
Copy link
Member Author

stevespringett commented Oct 4, 2021 •
edited
Loading

  • TODO: Add support for Properties to release notes

stevespringett and others added 2 commits October 4, 2021 20:19
@stevespringett
Added support for properties to release notes. #88 (comment)
a1e2909 
Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett
Added documentation to attachment text that states "Proactive control…
18d0a43 
…s such as input validation and sanitization should be employed to prevent misuse of attachment text". #88 (comment)

Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett
Copy link
Member Author

@coderpatros both recommendations have been implemented and include:

  • Add doc enhancement for attachment text to describe proactive controls
  • Add support for Properties to release notes

@stevespringett stevespringett added this to the 1.4 milestone Oct 18, 2021
@stevespringett stevespringett added the RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration label Nov 20, 2021
coderpatros
coderpatros approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@coderpatros coderpatros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@stevespringett
Corrected maxoccurs
62774d0 
Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett
Corrected maxoccurs
446fce1 
Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett
Added newline
efed5c4 
Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett
Changed release type from enum to string with a description on recomm…
2e8eca4 
…ended values.

Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett
Copy link
Member Author

@DarthHater Can I get approval on this please?

1 similar comment
@stevespringett
Copy link
Member Author

@DarthHater Can I get approval on this please?

@stevespringett stevespringett added RFC vote accepted and removed RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration labels Dec 17, 2021
@stevespringett
Merge remote-tracking branch 'origin/v1.4-dev' into v1.4-release-notes
b76ee21 
# Conflicts:
#	schema/bom-1.4-SNAPSHOT.proto
#	schema/bom-1.4-strict-SNAPSHOT.schema.json
@stevespringett stevespringett merged commit 0689101 into v1.4-dev Dec 20, 2021
@stevespringett stevespringett deleted the v1.4-release-notes branch December 20, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarthHater DarthHater DarthHater left review comments

@coderpatros coderpatros coderpatros approved these changes

Assignees
No one assigned
Labels
proposed core enhancement RFC vote accepted
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@stevespringett @coderpatros @DarthHater