Upgrade our argo fork to the latest version #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Auto-complete workflow names * Use cobra revision at fe5e611709b0c57fa4a89136deaa8e1d4004d053
…ities (argoproj#1065) * Issue argoproj#740 - System level workflow parallelism limits & priorities * Apply reviewer notes
Fix a small typo in demo.md that I encounted when reading through the getting started guide.
…amespace install manifests (argoproj#1116)
…1115) * Remove docker_lib mount volume which is not needed anymore * Remove unused hostPathDir
mlarrousse
reviewed
Apr 24, 2019
| ### Notes about upgrading from v2.2 | ||
|
|
||
| * Secrets are passed to the wait sidecar using volumeMounts instead of performing K8s API calls | ||
| performed by the. This is much more secure since it limits the privileges of the workflow pod |
There was a problem hiding this comment.
This isn't even.
Do we have to do something here?
mlarrousse
reviewed
Apr 24, 2019
mlarrousse
reviewed
Apr 24, 2019
| * `argo run` to run workflows against clusters without a controller - #794 | ||
| * UI – filtering to improve performance | ||
| ## v2.4 | ||
| * Persistence - support offloading of workflow state into database layer |
mlarrousse
reviewed
Apr 24, 2019
| * UI – filtering to improve performance | ||
| ## v2.4 | ||
| * Persistence - support offloading of workflow state into database layer | ||
| * Large workflow support (enabled by persistence feature) |
mlarrousse
reviewed
Apr 24, 2019
| @@ -6,6 +6,7 @@ import ( | |||
| "path/filepath" | |||
|
|
|||
| "github.com/argoproj/pkg/json" | |||
There was a problem hiding this comment.
not unless we need to modify it https://github.com/argoproj/pkg
mlarrousse
approved these changes
Apr 25, 2019
Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of a merge of
argoproj/argo:masterinto our fork, as well as a merge of argoproj#1067. We're pulling in about 8 months of bugfixes here.based on the changes to the make file im guessing our jenkins pipeline will need to change a lot