eventmanager: Extracted some logic to an external function #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoyvwac
force-pushed
the
fix/refactor/prefer-extracted-function-engine
branch
4 times, most recently
from
ea16f26
to
733a1bb
Compare
|
Related issue about conan currently failing: conan-io/conan#12007 |
tcoyvwac
force-pushed
the
fix/refactor/prefer-extracted-function-engine
branch
6 times, most recently
from
ab926a9
to
dbb9d83
Compare
tcoyvwac
force-pushed
the
fix/refactor/prefer-extracted-function-engine
branch
2 times, most recently
from
e6b5bb9
to
edf9535
Compare
tcoyvwac
force-pushed
the
fix/refactor/prefer-extracted-function-engine
branch
from
edf9535
to
de2fc2c
Compare
EventManager.{c.h}xx:
* Added namespace: `detail`.
* Added function: updatePlacementMode
* Added test cases for: EventManager: update_placement_mode.
tcoyvwac
force-pushed
the
fix/refactor/prefer-extracted-function-engine
branch
from
de2fc2c
to
07ed006
Compare
|
Kudos, SonarCloud Quality Gate passed! |
lizzyd710
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventManager.{c.h}xx:
detail.updatePlacementModeEventManager:updatePlacementMode.