Skip to content

Commit

Permalink
⬆️ Upgrade storybook to 7.0.0-rc.1 by running `pnpx storybook@next …
Browse files Browse the repository at this point in the history
…upgrade --prerelease --skip-check`, fixes `rc.0` doctrine regression

storybookjs/storybook#21399
FIXES storybookjs/storybook#21523
FIXES storybookjs/storybook#21527

Console: 
```bash
➜  tools git:(master) ✗ pnpx storybook@next upgrade --prerelease --skip-check
.../Library/pnpm/store/v3/tmp/dlx-97337  | +603 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
.../Library/pnpm/store/v3/tmp/dlx-97337  | Progress: resolved 624, reused 581, downloaded 22, added 603, done
 • Checking for latest versions of '@storybook/*' packagesinfo ,Using pnpm
info Upgrading /Users/worker/development/_REPRODUCTIONS/reproduction-storybook-symlinks-pnpm/tools/package.json
info 
info  @storybook/addon-essentials    ^7.0.0-beta.63  →  ^7.0.0-rc.1
info  @storybook/addon-interactions  ^7.0.0-beta.63  →  ^7.0.0-rc.1
info  @storybook/addon-links         ^7.0.0-beta.63  →  ^7.0.0-rc.1
info  @storybook/blocks              ^7.0.0-beta.63  →  ^7.0.0-rc.1
info  @storybook/react               ^7.0.0-beta.63  →  ^7.0.0-rc.1
info  @storybook/react-vite          ^7.0.0-beta.63  →  ^7.0.0-rc.1
info  storybook                      ^7.0.0-beta.63  →  ^7.0.0-rc.1
info 
info Run pnpm install to install new versions.
info ,
info 
info ,Using pnpm
info Upgrading /Users/worker/development/_REPRODUCTIONS/reproduction-storybook-symlinks-pnpm/tools/package.json
info 
info No dependencies.
info ,
 • Installing upgrades • Preparing to install dependencies. ✓


Packages: +809
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /Users/worker/Library/pnpm/store/v3
  Virtual store is at:             node_modules/.pnpm
Progress: resolved 830, reused 781, downloaded 28, added 809, done

dependencies:
+ react 18.2.0
+ react-dom 18.2.0

devDependencies:
+ @storybook/addon-essentials 7.0.0-rc.1
+ @storybook/addon-interactions 7.0.0-rc.1
+ @storybook/addon-links 7.0.0-rc.1
+ @storybook/blocks 7.0.0-rc.1
+ @storybook/react 7.0.0-rc.1
+ @storybook/react-vite 7.0.0-rc.1
+ @storybook/testing-library 0.0.14-next.1
+ @types/react 18.0.28
+ @types/react-dom 18.0.11
+ prop-types 15.8.1
+ storybook 7.0.0-rc.1
+ typescript 4.9.5
+ vite 4.1.4

The integrity of 1217 files was checked. This might have caused installation to take longer.
Done in 16.2s
. ✓

attention => Storybook now collects completely anonymous telemetry regarding usage.
This information is used to shape Storybook's roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://storybook.js.org/telemetry

➜  tools git:(master) ✗ pnpm run storybook                                   

> tools@ storybook /Users/worker/development/_REPRODUCTIONS/reproduction-storybook-symlinks-pnpm/tools
> storybook dev -p 6006

@storybook/cli v7.0.0-rc.1

info => Starting manager..
WARN No story files found for the specified pattern: stories/**/*.mdx
╭──────────────────────────────────────────────────────╮
│                                                      │
│   Storybook 7.0.0-rc.1 for react-vite started        │
│   127 ms for manager and 1.79 s for preview          │
│                                                      │
│    Local:            http://localhost:6006/          │
│    On your network:  http://192.168.178.102:6006/    │
│                                                      │
╰──────────────────────────────────────────────────────╯
```
  • Loading branch information
D1no committed Mar 12, 2023
1 parent 2316904 commit 839aabc
Show file tree
Hide file tree
Showing 3 changed files with 294 additions and 294 deletions.
20 changes: 10 additions & 10 deletions readme.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<sub>Reproduction was created with `pnpx storybook@next init --builder vite` on `node` version `18 LTS`. Consecutive update via `pnpx storybook@next upgrade --prerelease`</sub>
<sub>Reproduction was created with `pnpx storybook@next init --builder vite` on `node` version `18 LTS`. Consecutive update via `pnpx storybook@next upgrade --prerelease --skip-check`</sub>

Issue: [storybookjs/storybook/issues/21399](https://github.com/storybookjs/storybook/issues/21399)<br>
Storybook Version: `7.0.0-beta.63`
Storybook Version: `7.0.0-rc.1`

### Reproduction: No Storybook JSDocGen inside of Monorepo

Expand Down Expand Up @@ -53,7 +53,7 @@ cd tools/stories && ln -s ../../ui/ComponentAsSymlink ComponentAsSymlink
### System
Via `pnpx sb@next info` on 2023-03-09
Via `pnpx sb@next info` on 2023-03-12
```cpp
Environment Info:
Expand All @@ -69,11 +69,11 @@ Environment Info:
Firefox: 97.0.1
Safari: 16.3
npmPackages:
@storybook/addon-essentials: ^7.0.0-beta.63 => 7.0.0-beta.63
@storybook/addon-interactions: ^7.0.0-beta.63 => 7.0.0-beta.63
@storybook/addon-links: ^7.0.0-beta.63 => 7.0.0-beta.63
@storybook/blocks: ^7.0.0-beta.63 => 7.0.0-beta.63
@storybook/react: ^7.0.0-beta.63 => 7.0.0-beta.63
@storybook/react-vite: ^7.0.0-beta.63 => 7.0.0-beta.63
@storybook/testing-library: ^0.0.14-next.1 => 0.0.14-next.1
@storybook/addon-essentials: ^7.0.0-rc.1 => 7.0.0-rc.1
@storybook/addon-interactions: ^7.0.0-rc.1 => 7.0.0-rc.1
@storybook/addon-links: ^7.0.0-rc.1 => 7.0.0-rc.1
@storybook/blocks: ^7.0.0-rc.1 => 7.0.0-rc.1
@storybook/react: ^7.0.0-rc.1 => 7.0.0-rc.1
@storybook/react-vite: ^7.0.0-rc.1 => 7.0.0-rc.1
@storybook/testing-library: ^0.0.14-next.1 => 0.0.14-next.1
```
14 changes: 7 additions & 7 deletions tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@
"react-dom": "^18.2.0"
},
"devDependencies": {
"@storybook/addon-essentials": "^7.0.0-beta.63",
"@storybook/addon-interactions": "^7.0.0-beta.63",
"@storybook/addon-links": "^7.0.0-beta.63",
"@storybook/blocks": "^7.0.0-beta.63",
"@storybook/react": "^7.0.0-beta.63",
"@storybook/react-vite": "^7.0.0-beta.63",
"@storybook/addon-essentials": "^7.0.0-rc.1",
"@storybook/addon-interactions": "^7.0.0-rc.1",
"@storybook/addon-links": "^7.0.0-rc.1",
"@storybook/blocks": "^7.0.0-rc.1",
"@storybook/react": "^7.0.0-rc.1",
"@storybook/react-vite": "^7.0.0-rc.1",
"@storybook/testing-library": "^0.0.14-next.1",
"@types/react": "^18.0.28",
"@types/react-dom": "^18.0.11",
"prop-types": "^15.8.1",
"storybook": "^7.0.0-beta.63",
"storybook": "^7.0.0-rc.1",
"typescript": "^4.9.5",
"vite": "^4.1.4"
},
Expand Down
Loading

0 comments on commit 839aabc

Please sign in to comment.