Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No automatic date added #34

Merged
merged 2 commits into from
Feb 1, 2024
Merged

No automatic date added #34

merged 2 commits into from
Feb 1, 2024

Conversation

mishaschwartz
Copy link
Collaborator

Previously the date_added field was automatically added to the registry the first time that the update.py script was run for that node. This was done by checking whether the registry already had the date_added field for the given node and adding one if it was missing.

However, when executing the update.py script in the CI workflow, we read the registry from the main branch and apply the changes to the current_registry branch. This means that the date_added field is never added to the main branch, which means that the update.py script re-adds the date_added field every time.

This PR makes the date_added field into a manually added field that should be included when a new node is added. This adds another (very small) manual step when adding a new node but with the current CI configuration there's no good way to do this automatically anymore.

I've also updated the schema so it should be obvious when the date_added information is missing. This means we won't forget to add this info when adding new nodes.

Copy link
Collaborator

@alexandercyu alexandercyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with me

Copy link
Collaborator

@dchandan dchandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mishaschwartz mishaschwartz merged commit 34dc55e into main Feb 1, 2024
1 check passed
@mishaschwartz mishaschwartz deleted the no-automatic-date-added branch February 1, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants