Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketches possible fix to help #1124 #1125

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Sketches possible fix to help #1124 #1125

wants to merge 1 commit into from

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Sep 7, 2024

We're inconsistent as to when originating_functions is populated. So this tries to fix it for expander parameterize decorator at least.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

We're inconsistent as to when originating_functions is populated.
So this tries to fix it for expander parameterize decorator at least.
@skrawcz
Copy link
Collaborator Author

skrawcz commented Sep 7, 2024

Related to #1124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant