Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed response to CONNECT on local server #190

Closed
arfNZ opened this issue Jul 24, 2021 · 3 comments
Closed

Malformed response to CONNECT on local server #190

arfNZ opened this issue Jul 24, 2021 · 3 comments
Assignees
Labels

Comments

@arfNZ
Copy link

arfNZ commented Jul 24, 2021

When attempting to connect to a server without a connect block the response message is missing the source :server:

>> /CONNECT invalidserver.* 7325
<< NOTICE Arfie :Connect: No Connect block found for invalidserver.*.

On a remote server it works ok:

>> /CONNECT invalidserver.* 7325 midnight.*
<< :midnight.hub.dal.net NOTICE Arfie :Connect: No Connect block found for invalidserver.*.

Both znc and my client handle the message ok - but if I'm parsing the message to determine the origin, it's simply not there.

@github-actions
Copy link

Thanks for submitting your first issue! A member of the DALnet coder team will label it appropriately and provide follow-up

kobishmueli added a commit to kobishmueli/bahamut that referenced this issue Jul 24, 2021
@kobishmueli
Copy link
Member

Arfie: Thanks for letting us know, pull request #191 should fix this.

Kobi.

@kobishmueli kobishmueli self-assigned this Jul 24, 2021
eaescob added a commit that referenced this issue Jul 24, 2021
Fix a small bug where the "Connect: No Connect block found for %s" notice have no origin prefix (issue #190)
@eaescob
Copy link
Contributor

eaescob commented Aug 30, 2021

PR Merged

@eaescob eaescob closed this as completed Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants