Changes preparing for 2.2.0 release #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rscs
previously approved these changes
May 21, 2021
kobishmueli
previously approved these changes
May 21, 2021
rscs
previously approved these changes
May 21, 2021
Remove "inline" from verbose_to_opers to fix compile errors.
rscs
previously approved these changes
May 21, 2021
Unless we're intending to only show local clients, myclient() isn't useful here.
kobishmueli
previously approved these changes
May 24, 2021
rscs
previously approved these changes
Jun 3, 2021
rscs
reviewed
Jul 5, 2021
src/s_user.c
Outdated
| @@ -3412,6 +3418,11 @@ m_umode(aClient *cptr, aClient *sptr, int parc, char *parv[]) | |||
| hash_check_watch(sptr, RPL_LOGON); | |||
| } | |||
| } | |||
| else | |||
| { | |||
| sendto_one(sptr, ":%s NOTICE %s :*** Notice -- Server has not received hostmask type, please contact SRA.", | |||
There was a problem hiding this comment.
Arfie pointed out that we should change this to something other than "contact SRA" because this could be running on other networks outside of DALnet.
Plus, we don't want every single end-user contacting SRA for this, should something break. Maybe it should go to opers or a channel or something. Let's rethinking what makes sense.
|
Good suggestion, should we generalize to 'please contact the network's
staff via official help channels'?
Emilio Escobar / ***@***.***
…On Mon, Jul 5, 2021 at 1:08 PM Ryan Smith ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/s_user.c
<#184 (comment)>:
> @@ -3412,6 +3418,11 @@ m_umode(aClient *cptr, aClient *sptr, int parc, char *parv[])
hash_check_watch(sptr, RPL_LOGON);
}
}
+ else
+ {
+ sendto_one(sptr, ":%s NOTICE %s :*** Notice -- Server has not received hostmask type, please contact SRA.",
Arfie pointed out that we should change this to something other than
"contact SRA" because this could be running on other networks outside of
DALnet.
Plus, we don't want every single end-user contacting SRA for this, should
something break. Maybe it should go to opers or a channel or something.
Let's rethinking what makes sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#184 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQ2SO42PCUBOMNYHZ3V7DTWIGLFANCNFSM45IAGRWQ>
.
|
…handling this in the module.
rscs
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.