-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#371: [docs] use fixed doxygen version, add C++17 dependency, fix markup issues #375
Open
cz4rs
wants to merge
7
commits into
develop
Choose a base branch
from
371-fix-documentation-issues
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cz4rs
force-pushed
the
371-fix-documentation-issues
branch
from
November 12, 2024 15:17
e875824
to
0d7c370
Compare
cz4rs
force-pushed
the
371-fix-documentation-issues
branch
2 times, most recently
from
November 12, 2024 20:26
506bc95
to
ae2b9f7
Compare
cz4rs
requested review from
stmcgovern,
lifflander,
nmm0,
thearusable,
JacobDomagala,
nlslatt and
cwschilly
November 12, 2024 21:12
cz4rs
force-pushed
the
371-fix-documentation-issues
branch
from
November 12, 2024 21:15
ae2b9f7
to
eb28b90
Compare
cz4rs
commented
Nov 12, 2024
cz4rs
commented
Nov 12, 2024
cz4rs
commented
Nov 12, 2024
Comment on lines
85
to
+86
`checkpoint_virtual_serialize_root()` and | ||
`checkpoint_virtual_serialize_derived_from(T)` to inform *checkpoint* of the | ||
`checkpoint_virtual_serialize_derived_from(T)` to inform *magistrate* of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that checkpoint_virtual_serialize
macros were never renamed to magistrate_virtual_serialize
.
cz4rs
changed the title
371: [docs] use fixed doxygen version, add C++17 dependency, fix markup issues
#371: [docs] use fixed doxygen version, add C++17 dependency, fix markup issues
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #371
As the title says, plus a bunch of
checkpoint
->magistrate
renaming changes.Successful build from this branch: https://github.com/DARMA-tasking/magistrate/actions/runs/11805143657/job/32886943659?pr=375.