-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing fields: TextMatchInfo, HnswParams and CreatedAt. Also fixes failing tests because the Store field. #237
Add missing fields: TextMatchInfo, HnswParams and CreatedAt. Also fixes failing tests because the Store field. #237
Conversation
Not sure why the tests are failing at CircleCI, for me everything passes and the given errors were fixed already. |
Hi @solvingproblemswithtechnology, I'll take a look at why the tests are failing in the next couple of days. // Rune |
It seems like there's more collections that the ones created by the tests themselves. I guess you need to reset that typesense instance so it's clean again. |
The instance is always clean on each PR, so it has to be something with the code you have added, since everything works before the change, but I'll look into it in a few days. |
Nope, the tests were failing before I changed anything, it had something to do with the field Store being null instead of true (the default value when creating a collection). But yes, I'll wait for your input. |
Hi @solvingproblemswithtechnology, I've tried running the tests locally on the master branch HEAD commit and all tests pass without any issue, I've also repeated it multiple times without any issues. After that I tried checking out your PR and the tests fails, just like in the CI. If you have problem with running the tests locally on the current HEAD of the master branch, lets try to fix that first before looking into this PR. What OS are you running and are you sure that your Typesense test instance is 100% clean? |
Windows and yes! I'll try again and update the PR, thanks for testing it! |
Cheers @solvingproblemswithtechnology, I'll keep that in mind when I upgrade the library to target 27.0. |
@solvingproblemswithtechnology thanks for the contribution, I've made a new release (7.14.0) with the changes. 👍 |
Hey there!
I made some time to send a PR with some missing fields!
Thank you!