-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MetadataService with GetHealth and GetVersion #267
Conversation
Apologies for the manier protolint fix commits haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename AdministrationtService
to MetadataService
or something that is VERY unlikely to ever have a name clash.
Administration
is such a generic term that I could see it being useful in other contexts.
And yeah, a squash at the end will be good 😁
Updated the name to |
@dutchie032 Branch needs rebasing with merge conflicts, PR and README still says |
@rurounijones conflicts resolved and namings fixed |
Added an additional service. "MetadataService" for admin functionality that does not touch DCS itself.
GetHealth
=> for getting the gRPC server statusGetVersion
=> for getting the version of the cargo package.Nothing too fancy, but can be handy for the client and verification.
Example requests: