Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MetadataService with GetHealth and GetVersion #267

Merged
merged 12 commits into from
Sep 28, 2024

Conversation

dutchie032
Copy link
Collaborator

@dutchie032 dutchie032 commented Sep 10, 2024

Added an additional service. "MetadataService" for admin functionality that does not touch DCS itself.

GetHealth => for getting the gRPC server status
GetVersion => for getting the version of the cargo package.

Nothing too fancy, but can be handy for the client and verification.

Example requests:

image
image

@dutchie032
Copy link
Collaborator Author

dutchie032 commented Sep 10, 2024

Apologies for the manier protolint fix commits haha
Recommend possibly squashing commit anyway

Copy link
Contributor

@rurounijones rurounijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename AdministrationtService to MetadataService or something that is VERY unlikely to ever have a name clash.

Administration is such a generic term that I could see it being useful in other contexts.

And yeah, a squash at the end will be good 😁

@dutchie032
Copy link
Collaborator Author

dutchie032 commented Sep 24, 2024

Updated the name to MetadataService. Chose AdministrationService due to it's administrative nature, but can imagine that indeed in the future there might be more "Administrator" type of services, so Metadata works for me

@rurounijones
Copy link
Contributor

@dutchie032 Branch needs rebasing with merge conflicts, PR and README still says AdministrationService

@dutchie032 dutchie032 changed the title Added AdministrationService with GetHealth and GetVersion Added MetadataService with GetHealth and GetVersion Sep 28, 2024
@dutchie032
Copy link
Collaborator Author

@rurounijones conflicts resolved and namings fixed

@rurounijones rurounijones merged commit 64d5dc3 into DCS-gRPC:main Sep 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants