Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listing for SmartBatteries and related tests #176

Merged
merged 4 commits into from
May 31, 2024

Conversation

berendhaan
Copy link
Collaborator

This PR adds a new method to the API to list the current users connected batteries, for example the Sessy.

If you see something let me know :-) I'm not a python dev by day (or night)

In a next PR I will add a method to get the 'earnings' per connected Smart Battery of the user.

@DCSBL
Copy link
Owner

DCSBL commented May 29, 2024

Oh awesome. Will take a look at this asap!

@berendhaan
Copy link
Collaborator Author

The failing flake8 task does not look (completely) related to this PR

unable to find qualified name for module: example.py python_frank_energie/models.py:426:1: D400 First line should end with a period python_frank_energie/models.py:450:1: D106 Missing docstring in public nested class tests/test_smart_batteries.py:1:1: D100 Missing docstring in public module

tests/test_smart_batteries.py Show resolved Hide resolved
python_frank_energie/models.py Outdated Show resolved Hide resolved
python_frank_energie/models.py Outdated Show resolved Hide resolved
python_frank_energie/models.py Show resolved Hide resolved
Copy link
Owner

@DCSBL DCSBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now way to test this, but it looks good. The added unit test is nice!

Thanks!

@DCSBL DCSBL merged commit 34e0e73 into DCSBL:main May 31, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants