Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run initial migrate command in background. #457

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

dchiller
Copy link
Collaborator

@dchiller dchiller commented Jun 2, 2022

Running the migrate command results in a complete reindexing of the
Solr backend. Running in background allows access to website while
indexing is completed.

Running the migrate command results in a complete reindexing of the
Solr backend. Running in background allows access to website while
indexing is completed.
Copy link
Member

@napulen napulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial solr reindexing should only have the basic model templates, right?

I don't see harm in this change, but I am curious on the time elapsed on this makemigrations. It shouldn't be much different from the one running on the background, is it?

@dchiller
Copy link
Collaborator Author

dchiller commented Jun 3, 2022

You are correct, unless you are rebooting the docker container, but keeping the same database....in other words, what if we make a change to a view, but don't want to have to reimport everything or remap everything if the db is fine.

In that case, everything in the db is reindexed.

Copy link
Member

@napulen napulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging

@napulen napulen merged commit ff20b4d into DDMAL:main Jun 3, 2022
@dchiller dchiller deleted the initial_indexing_background branch July 7, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants