Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUBY 3083 wcr wex frae bo show password hint functionality does not work #13

Conversation

jjromeo
Copy link
Contributor

@jjromeo jjromeo commented Jun 14, 2024

  • Update govuk-frontend version to 5.4
  • Update Rake task for creating vendor files from govuk-frontend

jjromeo added 15 commits June 11, 2024 16:15
- Consolidated asset copying logic into `copy_assets` method.
- Added new task `minified_css` for handling minified CSS.
- Simplified `assets` task to iterate over a list of task names.
- Updated paths to align with `govuk-frontend` distribution structure.
- Add base SCSS file and import settings, tools, and helpers
- Add all.scss to import index
- Add components/_all.scss with deprecation warning for 'govuk/components/all' import
- Add components/_index.scss with imports for all individual component styles
- Add accordion component styles
- Add back-link component styles
- Add breadcrumbs component styles
- Add button component styles
- Add character-count component styles
- Add favicon.svg
- Add govuk-icon-180.png
- Add govuk-icon-192.png
- Add govuk-icon-512.png
- Add govuk-icon-mask.svg
- Add defra_ruby_template.js with GOV.UK frontend components and utilities
- Update CI workflow to run RSpec tests
- Add .rspec configuration file
- Update Gemfile and Gemfile.lock to include RSpec
- Generate spec_helper.rb with RSpec configuration
- Add initial Rake task spec for 'assets'
@jjromeo jjromeo force-pushed the RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work branch from 7b33ff0 to f87706a Compare June 17, 2024 11:26
@jjromeo jjromeo force-pushed the RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work branch from 592ccaf to f3d50cc Compare June 17, 2024 11:57
@jjromeo jjromeo force-pushed the RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work branch 3 times, most recently from 0904751 to f298cb8 Compare June 17, 2024 15:01
@jjromeo jjromeo force-pushed the RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work branch from f298cb8 to b0b5f63 Compare June 17, 2024 15:10
@jjromeo jjromeo merged commit a2a53c9 into main Jun 17, 2024
1 check passed
@jjromeo jjromeo added bug Something isn't working housekeeping labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants