-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUBY 3083 wcr wex frae bo show password hint functionality does not work #13
Merged
jjromeo
merged 19 commits into
main
from
RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work
Jun 17, 2024
Merged
RUBY 3083 wcr wex frae bo show password hint functionality does not work #13
jjromeo
merged 19 commits into
main
from
RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjromeo
commented
Jun 14, 2024
•
edited
Loading
edited
- Update govuk-frontend version to 5.4
- Update Rake task for creating vendor files from govuk-frontend
- Consolidated asset copying logic into `copy_assets` method. - Added new task `minified_css` for handling minified CSS. - Simplified `assets` task to iterate over a list of task names. - Updated paths to align with `govuk-frontend` distribution structure.
- Add base SCSS file and import settings, tools, and helpers - Add all.scss to import index - Add components/_all.scss with deprecation warning for 'govuk/components/all' import - Add components/_index.scss with imports for all individual component styles - Add accordion component styles - Add back-link component styles - Add breadcrumbs component styles - Add button component styles - Add character-count component styles
- Add favicon.svg - Add govuk-icon-180.png - Add govuk-icon-192.png - Add govuk-icon-512.png - Add govuk-icon-mask.svg - Add defra_ruby_template.js with GOV.UK frontend components and utilities
PaulDoyle-EA
approved these changes
Jun 17, 2024
- Update CI workflow to run RSpec tests - Add .rspec configuration file - Update Gemfile and Gemfile.lock to include RSpec - Generate spec_helper.rb with RSpec configuration - Add initial Rake task spec for 'assets'
jjromeo
force-pushed
the
RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work
branch
from
June 17, 2024 11:26
7b33ff0
to
f87706a
Compare
…ble tasks before each test
jjromeo
force-pushed
the
RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work
branch
from
June 17, 2024 11:57
592ccaf
to
f3d50cc
Compare
PaulDoyle-EA
approved these changes
Jun 17, 2024
jjromeo
force-pushed
the
RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work
branch
3 times, most recently
from
June 17, 2024 15:01
0904751
to
f298cb8
Compare
jjromeo
force-pushed
the
RUBY-3083-wcr-wex-frae-bo-show-password-hint-functionality-does-not-work
branch
from
June 17, 2024 15:10
f298cb8
to
b0b5f63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.