Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

change coverage checker to work with es modules #34

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

csaltmountain
Copy link
Collaborator

Previously we were using nyc to generate code coverage. It wasn't actually working. It doesn't seem to work when using ES modules — see istanbuljs/nyc#1353

Have changed to use c8 as recommended in the above issue.

Have updated the make test command so that a different configuration is run locally so we get a terminal output of the coverage:

Screenshot 2023-11-27 at 12 28 59

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@hadidefra hadidefra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@csaltmountain csaltmountain merged commit 54e4b4a into main Nov 27, 2023
8 checks passed
@csaltmountain csaltmountain deleted the feature/code-coverage branch November 27, 2023 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants