Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus label left against rspec tests stops all tests running #43

Closed
Cruikshanks opened this issue Nov 28, 2016 · 1 comment
Closed

focus label left against rspec tests stops all tests running #43

Cruikshanks opened this issue Nov 28, 2016 · 1 comment
Assignees
@Cruikshanks
Labels
bug Something isn't working

Comments

@Cruikshanks
Copy link
Member

In PR #42 the label focus: true was left against the tests written for changes which were being done to the Quke::Configuration class.

This means that when Travis-CI now runs its only running these tests. These labels need to be removed and ideally this needs to be prevented from happening again.
@Cruikshanks Cruikshanks added the bug Something isn't working label Nov 28, 2016
@Cruikshanks Cruikshanks self-assigned this Nov 28, 2016
Cruikshanks added a commit that referenced this issue Nov 28, 2016
@Cruikshanks
Fix rspec focus label left in tests
466dce0 
This change removes a focus label left in a test in the last PR #42, as per issue #43.

It also updates `.travis.yml` to add a new check for focus labels to attempt to prevent it happening again. If the check finds a match it will break the build.
@Cruikshanks Cruikshanks mentioned this issue Nov 28, 2016
Merged
Cruikshanks added a commit that referenced this issue Nov 28, 2016
@Cruikshanks
Fix rspec focus label left in tests
83bec29 
This change removes a focus label left in a test in the last PR #42, as per issue #43.

It also updates `.travis.yml` to add a new check for focus labels to attempt to prevent it happening again. If the check finds a match it will break the build.
Cruikshanks added a commit that referenced this issue Nov 28, 2016
@Cruikshanks
Fix rspec focus label left in tests
fab75ea 
This change removes a focus label left in a test in the last PR #42, as per issue #43.

It also updates `.travis.yml` to add a new check for focus labels to attempt to prevent it happening again. If the check finds a match it will break the build.
Cruikshanks added a commit that referenced this issue Nov 28, 2016
@Cruikshanks
Fix rspec focus label left in tests
f8d716d 
This change removes a focus label left in a test in the last PR #42, as per issue #43.

It also updates `.travis.yml` to add a new check for focus labels to attempt to prevent it happening again. If the check finds a match it will break the build.
Cruikshanks added a commit that referenced this issue Nov 28, 2016
@Cruikshanks
Fix rspec focus label left in tests
df71d57 
This change removes a focus label left in a test in the last PR #42, as per issue #43.

It also updates `.travis.yml` to add a new check for focus labels to attempt to prevent it happening again. If the check finds a match it will break the build.
Cruikshanks added a commit that referenced this issue Nov 28, 2016
@Cruikshanks
Fix rspec focus label left in tests
6f082bf 
This change removes a focus label left in a test in the last PR #42, as per issue #43.

It also updates `.travis.yml` to add a new check for focus labels to attempt to prevent it happening again. If the check finds a match it will break the build.
@Cruikshanks
Copy link
Member Author

Fixed in PR #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cruikshanks Cruikshanks

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cruikshanks