Add browserstack support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found when a test failed the output actually showed this exception was being thrown. The root was the way the after hook was using the `return` statement. This change modifies the structure of the hook to fix that error.
Cruikshanks
force-pushed
the
feature/add-browserstack-support
branch
8 times, most recently
from
7b51183 to
b0bb2fd
Compare
[Browserstack](https://www.browserstack.com/) is an online testing solution which allows you to run your web app in a multitude of platform, OS and browser combinations. Our QA representatives have expressed an interest in being able to run tests written in Quke through Browserstack hence this change adds that ability. The changes cover - Updating `lib/quke/config.rb` to handle the new configuration details needed for browserstack - Updating `.config.example.yml` with details of the new options - Adding support for setting the browserstack credentials in environment variables as well as in a `.config.yml` file - Adding a code to cover registration of the browserstack driver - Moving all driver registration to its own class - New rake task to quickly run Quke using the browserstack driver - Update to the default profile to cover allow separate running of @Quke tests and @browserstack tests - New feature and steps to confirm browserstack is running (cannot test against the local server at this time using browserstack.local) - Updated documentation on how to integrate with Browserstack - Updated travis.yml build config to include browserstack integration test
Cruikshanks
force-pushed
the
feature/add-browserstack-support
branch
from
b0bb2fd to
55cb453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for running the tests using Browserstack to Quke.