Fix Cucumber not loading lib/features correctly #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Cucumber is called in the context of the executing script (project) and not the gem, when it is telling Cucumber to reference `lib/features` Cucumber cannot see it. This means `env.rb` never gets loaded and therefore everything blows up. This change corrects how we specify our default arguments, ensuring we correctly determine what the full path to the gems `lib/features` folder is, and passing that to Cucumber.
Cruikshanks
force-pushed
the
fix/not-finding-lib-features-folder
branch
from
d5c9f18 to
544d546
Compare
Cruikshanks
added a commit
that referenced
this pull request
Oct 5, 2016
Similar to 544d54 (PR #35) Quke was not loading the .config.yml file as set by the user, again because it was thinking in terms of its location and not the calling projects. This change corrects that when calling `Quke::Configuration.file_location`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Cucumber is called in the context of the executing script (project) and not the gem, when it is telling Cucumber to reference
lib/featuresCucumber cannot see it. This meansenv.rbnever gets loaded and therefore everything blows up.This change corrects how we specify our default arguments, ensuring we correctly determine what the full path to the gems
lib/featuresfolder is, and passing that to Cucumber.