Save custom quke args to global env vars #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change saves the values of DRIVER and PAUSE (qukes custom arguments) to global variables so they can be accessed from anywhere else in the code base. The expected use of these variables is in things like extra functionality around fail scenarios, but at this point its just about making them accessible.
Developers within our teams at the EA generally use rubocop to ensure the code they are writing is consistent with community conventions. In order to capture the values of quke's custom arguments for use elsewhere we have saved them to global variables which rubocop raises an excption for. We know that global variables are not recommended hence rubocop flagging them, but in this case and due to the intended audience of quke (people who are not necessarily developers) it was felt to be the best solution. So this change adds a `.rubocop.yml` file with some default settings (display cop names and style guide link in errors) and GlobalVars disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change saves the values of DRIVER and PAUSE (qukes custom arguments) to global variables so they can be accessed from anywhere else in the code base. The expected use of these variables is in things like extra functionality around fail scenarios, but at this point its just about making them accessible.