More flexibility setting browserstack capabilities #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change Quke looked for specific values in the
.config.yml
file and then set those as capabilities in the Browserstack driver. However we've had a coup0le of requests for specific things to be passed through. Continuing to support Browserstack in this way would mean continually having to dive back into the code and adding support for each and every flag.So instead this updates Quke to be more flexible. Now it will simply pass in the values set in
.config.yml
(under browserstack) to theSelenium::WebDriver::Remote::Capabilities
object we create, using the keys in the config as the names of the keys in the capabilities.Essentially we're moving to an assumption that the user knows what they are doing when it come to Browserstack. So we'll handle setting up the driver and Quke, but get out of their way when it comes to browserstack.
It should be noted this is a breaking change for Browserstack users. Both the username and auth_key, and the capabilities to be set for the test used to be found directly under the node
browserstack:
. Now Quke will expect them to be placed underbrowserstack: capabilities:
for example