Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexibility setting browserstack capabilities #67

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

Cruikshanks
Copy link
Member

@Cruikshanks Cruikshanks commented Dec 4, 2017

Prior to this change Quke looked for specific values in the .config.yml file and then set those as capabilities in the Browserstack driver. However we've had a coup0le of requests for specific things to be passed through. Continuing to support Browserstack in this way would mean continually having to dive back into the code and adding support for each and every flag.

So instead this updates Quke to be more flexible. Now it will simply pass in the values set in .config.yml (under browserstack) to the Selenium::WebDriver::Remote::Capabilities object we create, using the keys in the config as the names of the keys in the capabilities.

Essentially we're moving to an assumption that the user knows what they are doing when it come to Browserstack. So we'll handle setting up the driver and Quke, but get out of their way when it comes to browserstack.

It should be noted this is a breaking change for Browserstack users. Both the username and auth_key, and the capabilities to be set for the test used to be found directly under the node browserstack:. Now Quke will expect them to be placed under browserstack: capabilities: for example

browserstack:
  username: jdoe
  auth_key: 123456789ABCDE
  capabilities:
    project: 'Adding browserstack support'
    build: 'Version 1'

Prior to this change **Quke** looked for specific values in the `.config.yml` file and then set those as capabilities in the Browserstack driver. However we've had a coup0le of requests for specific things to be passed through. Continuing to support Browserstack in this way would mean continually having to dive back into the code and adding support for each and every flag.

So instead this updates **Quke** to be more flexible. Now it will simply passing in the values set in `.config.yml` (under browserstack) to the `Selenium::WebDriver::Remote::Capabilities` object we create, using the keys in the config as the names of the keys in the capabilities.

Essentially we're moving to an assumption that the user knows what they are doing when it come to Browserstack. So we'll handle setting up the driver and **Quke**, but get out of their way when it comes to browserstack.

It should be noted this is a breaking change for Browserstack users. Both the username and auth_key, and the capabilities to be set for the test used to be found directly under the node `browserstack:`. Now Quke will expect them to be placed under `browserstack: capabilities:` for example

```yaml
browserstack:
  username: jdoe
  auth_key: 123456789ABCDE
  capabilities:
    project: 'Adding browserstack support'
    build: 'Version 1'
```
@Cruikshanks Cruikshanks added the enhancement New feature or request label Dec 4, 2017
@Cruikshanks Cruikshanks self-assigned this Dec 4, 2017
@Cruikshanks Cruikshanks merged commit 28978ed into master Dec 4, 2017
@Cruikshanks Cruikshanks deleted the feature/more-flexible-browserstack-support branch December 4, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant