Use cucumber --fast-fail to stop on error #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change we handled telling Cucumber whether to quit or not should an error occur and `stop_on_error` is set. However whilst looking into another change I spotted that Cucumber now has a `--fail-fast` option built in. So the main thrust of this change is to use this rather than hand crank our own. This meant though that the logic to determine what arguments to set for cucumber which we pass to ParallelTests first needed to know about the flag. I decided this meant the method which generates the arg now needed to access the configuration for multiple attributes, none of them actually to do with parallel tests. Hence this change also refactors the `ParallelConfiguration` and `Configuration` to move the logic into `Configuration`. We also changed how `ParallelConfiguration` is initialized as it already needed access to config attributes, but now it also needed to access our new helper method for the cucumber arg.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change we handled telling Cucumber whether to quit or not should an error occur and
stop_on_erroris set.However whilst looking into another change I spotted that Cucumber now has a
--fail-fastoption built in.So the main thrust of this change is to use this rather than hand crank our own. This meant though that the logic to determine what arguments to set for cucumber which we pass to ParallelTests first needed to know about the flag.
I decided this meant the method which generates the arg now needed to access the configuration for multiple attributes, none of them actually to do with parallel tests.
Hence this change also refactors the
ParallelConfigurationandConfigurationto move the logic intoConfiguration. We also changed howParallelConfigurationis initialized as it already needed access to config attributes, but now it also needed to access our new helper method for the cucumber arg.