Fix variable defaults #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to terraform issue: hashicorp/terraform#24142 We can't pass a null value to a module as it is passed explicitly instead of using the default set inside of the module. As a workaround we set empty string as default and set local variables conditionally.
saliceti
force-pushed
the
grafana-runtime
branch
from
a183ca6
to
b3be2d6
Compare
sfawcett123
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related to terraform issue: hashicorp/terraform#24142
We can't pass a null value to a module as it is passed explicitly
instead of using the default set inside of the module.
As a workaround we set empty string as default and set local variables
conditionally.
How to review
Try to use default values for grafana runtime, prometheus memory and disk