Feat/cleanup

src/Dfe.PlanTech.Infrastructure.Contentful/Helpers/GetEntitiesException.cs

@@ -1,6 +1,12 @@
-namespace Dfe.PlanTech.Infrastructure.Contentful.Helpers;
+using System.Runtime.Serialization;
+
+namespace Dfe.PlanTech.Infrastructure.Contentful.Helpers;
 
 [Serializable]
-public class GetEntitiesException(string? message) : Exception(message)
+public class GetEntitiesException(string? message) : Exception(message), ISerializable
 {
+
+    protected GetEntitiesException(SerializationInfo info, StreamingContext context) : this(null)
+    {
+    }
 }

tests/Dfe.PlanTech.Infrastructure.Contentful.UnitTests/Persistence/ContentfulRepositoryTests.cs

@@ -156,5 +156,16 @@ public async Task GetEntityById_Should_Throw_GetEntitiesIDException_When_Duplica
 
             await Assert.ThrowsAsync<GetEntitiesException>(() => repository.GetEntityById<TestClass>(testId));
         }
+
+        [Fact]
+        public async Task GetEntityById_Should_Throw_GetEntitiesIDException_With_Correct_Exception_Message_When_DuplicateIds()
+        {
+            var testId = "duplicateId";
+
+            ContentfulRepository repository = new ContentfulRepository(new NullLoggerFactory(), _clientSubstitute);
+
+            var exceptionMessage = await Assert.ThrowsAsync<GetEntitiesException>(() => repository.GetEntityById<TestClass>(testId));
+            Assert.Equal("Found more than 1 entity with id duplicateId", exceptionMessage.Message);
+        }
     }
 }