Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gps alignment on Linux #628

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix gps alignment on Linux #628

merged 1 commit into from
Aug 4, 2023

Conversation

lethosor
Copy link
Member

@lethosor lethosor commented Aug 4, 2023

Should double-check that the size of gps remains the same (221160) on Windows.

@myk002
Copy link
Member

myk002 commented Aug 4, 2023

Should double-check that the size of gps remains the same (221160) on Windows

Check type sizes says yes

@ab9rf
Copy link
Member

ab9rf commented Aug 4, 2023

Check type sizes says yes

it was my impression that the check type sizes GHA only generated reports for linux sizes

@myk002
Copy link
Member

myk002 commented Aug 4, 2023

indeed, my mistake -- can we fix that, now that we have windows runners?

@ab9rf
Copy link
Member

ab9rf commented Aug 4, 2023

I have confirmed that sizeof(gps) is still 221160 on windows with these changes applied

@myk002 myk002 merged commit dd19d00 into DFHack:master Aug 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants