[beta] Development Build v21 • Beta. #69
DIDIRUS4Annotations
8 warnings
|
useless use of `format!`:
theseus/src/state/mod.rs#L196
warning: useless use of `format!`
--> theseus/src/state/mod.rs:196:53
|
196 | let _ = discord_rpc.force_set_activity(&format!("{}", selected_phrase), true).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
|
useless use of `format!`:
theseus/src/state/discord.rs#L272
warning: useless use of `format!`
--> theseus/src/state/discord.rs:272:32
|
272 | self.set_activity(&format!("{}", selected_phrase), reconnect_if_fail).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
theseus/src/state/discord.rs#L166
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> theseus/src/state/discord.rs:166:29
|
166 | .small_text(&build_download)
| ^^^^^^^^^^^^^^^ help: change this to: `build_download`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
unnecessary parentheses around `if` condition:
theseus/src/api/download.rs#L24
warning: unnecessary parentheses around `if` condition
--> theseus/src/api/download.rs:24:19
|
24 | } else if (os_type.to_lowercase() == "MacOS".to_lowercase()) {
| ^ ^
|
help: remove these parentheses
|
24 - } else if (os_type.to_lowercase() == "MacOS".to_lowercase()) {
24 + } else if os_type.to_lowercase() == "MacOS".to_lowercase() {
|
|
|
unnecessary parentheses around `if` condition:
theseus/src/api/download.rs#L18
warning: unnecessary parentheses around `if` condition
--> theseus/src/api/download.rs:18:12
|
18 | if (os_type.to_lowercase() == "Windows".to_lowercase()) {
| ^ ^
|
help: remove these parentheses
|
18 - if (os_type.to_lowercase() == "Windows".to_lowercase()) {
18 + if os_type.to_lowercase() == "Windows".to_lowercase() {
|
|
|
unnecessary parentheses around `if` condition:
theseus/src/api/download.rs#L16
warning: unnecessary parentheses around `if` condition
--> theseus/src/api/download.rs:16:8
|
16 | if (auto_update_supported) {
| ^ ^
|
= note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
|
16 - if (auto_update_supported) {
16 + if auto_update_supported {
|
|
|
braces around Deserialize is unnecessary:
theseus/src/api/hydra/complete.rs#L3
warning: braces around Deserialize is unnecessary
--> theseus/src/api/hydra/complete.rs:3:1
|
3 | use serde::{Deserialize};
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> theseus/src/lib.rs:7:9
|
7 | #![warn(unused_import_braces)]
| ^^^^^^^^^^^^^^^^^^^^
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|