Skip to content

Merge commit '6699b4cb33a6a10b7a7c282360cea6b23b719b55' into beta #84

Merge commit '6699b4cb33a6a10b7a7c282360cea6b23b719b55' into beta

Merge commit '6699b4cb33a6a10b7a7c282360cea6b23b719b55' into beta #84

Triggered via push April 4, 2024 16:04
Status Failure
Total duration 2m 8s
Artifacts

gui-build.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
build
Process completed with exit code 1.
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build: theseus_gui/src/components/ui/AccountsCard.vue#L34
Expected a linebreak before this attribute
build: theseus_gui/src/components/ui/AccountsCard.vue#L62
Expected a linebreak before this attribute
build: theseus_gui/src/components/ui/AccountsCard.vue#L119
Attribute "v-model" should go before "type"
build: theseus_gui/src/pages/Settings.vue#L588
Attribute "id" should go before "class"
useless use of `format!`: theseus/src/state/mod.rs#L196
warning: useless use of `format!` --> theseus/src/state/mod.rs:196:53 | 196 | let _ = discord_rpc.force_set_activity(&format!("{}", selected_phrase), true).await; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
useless use of `format!`: theseus/src/state/discord.rs#L272
warning: useless use of `format!` --> theseus/src/state/discord.rs:272:32 | 272 | self.set_activity(&format!("{}", selected_phrase), reconnect_if_fail).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: theseus/src/state/discord.rs#L166
warning: this expression creates a reference which is immediately dereferenced by the compiler --> theseus/src/state/discord.rs:166:29 | 166 | .small_text(&build_download) | ^^^^^^^^^^^^^^^ help: change this to: `build_download` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
you are explicitly cloning with `.map()`: theseus/src/event/mod.rs#L26
warning: you are explicitly cloning with `.map()` --> theseus/src/event/mod.rs:26:9 | 26 | / EVENT_STATE 27 | | .get_or_try_init(|| async { 28 | | Ok(Arc::new(Self { 29 | | app, ... | 33 | | .await 34 | | .map(Arc::clone) | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 26 ~ EVENT_STATE 27 + .get_or_try_init(|| async { 28 + Ok(Arc::new(Self { 29 + app, 30 + loading_bars: RwLock::new(HashMap::new()), 31 + })) 32 + }) 33 + .await.cloned() |
braces around Deserialize is unnecessary: theseus/src/api/hydra/complete.rs#L3
warning: braces around Deserialize is unnecessary --> theseus/src/api/hydra/complete.rs:3:1 | 3 | use serde::{Deserialize}; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> theseus/src/lib.rs:7:9 | 7 | #![warn(unused_import_braces)] | ^^^^^^^^^^^^^^^^^^^^