-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SM-4 - device_data VIN from fingerprint #55
SM-4 - device_data VIN from fingerprint #55
Conversation
SM-4 Get VIN from Verified credentials instead of Loggers
As dimo, we want the VIN in our device data snapshot to be captured from the fingerprint topic, not from the device status topic, as the latter should be more accurate & have more data. In device-data-api we want to listen to the fingerprint topic and process the messages with following logic:
Now, the problem you'll have is that this column is also updated by the existing device status topic this service currently ingests. We only want vin to be updated from the fingerprint topic.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- no need to do VIN credentials here, this is already being handled by devices-api
- remove any unneeded code
- if want to verify the eth address exists or get the user_device id, there is a grpc call in devices-api to get user device by eth addr.
Proposed Changes
For AutoPi's, we currently get the VIN from whatever VIN logger may be active. We want to move to use our own built in VIN logger which we use for the "fingerprint". In theory, this should get us more coverage for VIN since it tries multiple different ways to get the VIN. It will also serve to help us find areas of improvement and bugs with our current custom edge-network logger (if for instance we see less VIN's coming through).
Impacted Routes
Caveats