Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-4 - device_data VIN from fingerprint #55

Merged
merged 16 commits into from
Oct 19, 2023

Conversation

rhvivancoeffio
Copy link
Contributor

@rhvivancoeffio rhvivancoeffio commented Oct 11, 2023

Proposed Changes

For AutoPi's, we currently get the VIN from whatever VIN logger may be active. We want to move to use our own built in VIN logger which we use for the "fingerprint". In theory, this should get us more coverage for VIN since it tries multiple different ways to get the VIN. It will also serve to help us find areas of improvement and bugs with our current custom edge-network logger (if for instance we see less VIN's coming through).

Impacted Routes

Caveats

@linear
Copy link

linear bot commented Oct 11, 2023

SM-4 Get VIN from Verified credentials instead of Loggers

As dimo, we want the VIN in our device data snapshot to be captured from the fingerprint topic, not from the device status topic, as the latter should be more accurate & have more data.

In device-data-api we want to listen to the fingerprint topic and process the messages with following logic:

  • capture VIN from message
  • update user_device_data → signals column, which is a jsonb column
  • specifically, set the json node for vin including the timestamp to be up to date
    • example:

      {"vin": {"value": "JTME6RFV0ND522512", "timestamp": "2023-07-06T09:16:15Z"}
      

Now, the problem you'll have is that this column is also updated by the existing device status topic this service currently ingests. We only want vin to be updated from the fingerprint topic.

  • modify existing device status ingest processor to ignore the vin property and not set it in the json.

Copy link
Member

@JamesReate JamesReate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no need to do VIN credentials here, this is already being handled by devices-api
  • remove any unneeded code
  • if want to verify the eth address exists or get the user_device id, there is a grpc call in devices-api to get user device by eth addr.

@JamesReate JamesReate changed the title SM-4 - VIN Verified SM-4 - device_data VIN from fingerprint Oct 11, 2023
@JamesReate JamesReate self-requested a review October 11, 2023 17:41
@JamesReate JamesReate self-requested a review October 13, 2023 18:52
@JamesReate JamesReate merged commit 2ea0606 into main Oct 19, 2023
3 checks passed
@JamesReate JamesReate deleted the device-data-api-vin-from-verified-credentials branch October 19, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants