AS-3208 - error codes endpoints with tokenID #419
Conversation
mateuszpohl
changed the title
|
Ah the |
changed |
| // @Failure 404 {object} helpers.ErrorRes "Vehicle not found" | ||
| // @Security BearerAuth | ||
| // @Router /user/vehicle/{tokenID}/error-codes [post] | ||
| func (udc *UserDevicesController) QueryDeviceErrorCodesByTokenID(c *fiber.Ctx) error { |
There was a problem hiding this comment.
Is this the same function as QueryDeviceErrorCodes other than the ud lookup? If so we can just use a function instead of duplicating the code.
There was a problem hiding this comment.
These are new ones using vehicle tokenID instead of legacy device ID, the old ones will be removed in future releases, we'll also drop the user_device_id column from error_code_queries table at that point.
There was a problem hiding this comment.
Let's mark those as deprecated then
Proposed Changes
user_device_token_idinerror_code_queries(migration, model changes)/error-codes/*endpoints usingtokenIDinstead ofuserDeviceID/clearendpoint status codes aligned with the spec (404/429)Note
For now this new field is nullable, since we still may have some devices without a tokenID. Making it not-nullable also breaks other parts (e.g. old version, that we will remove in the future) and older unit tests.