-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v7r1] ComponentInstaller uses --cfg #4690
Conversation
af4171f
to
1de912d
Compare
a066679
to
dc7379c
Compare
Unfortunately, there is no possibility at the moment to have a job allowed to fail, while having the green arrow for the tests. So I propose to split this PR, and we will merge the CI part once this is resolved actions/runner#2347 |
e18495e
to
9ed5183
Compare
@chrisburr any idea why all the PRs have issues starting all the tests lately ? Do we reach a quota or something ? |
There isn't a quota for public projects. I think it's just instability on the GitHub side with an API call getting lost somewhere. The uptime shown on their status page isn't great and has been getting worse over the last few months. I've opened a support ticket about it. |
Yeah I did check the status page but since it was green for the days we had issues, I assumed it was something else... |
I got an impressively quick response:
And indeed, the actions overview shows the run as completed even if the detailed page doesn't. If anyone sees it happen again let me know and I'll continue the thread. |
The comment in the op should be adapted. Anyway the main question is: do you still need to add something? |
Ready to go |
There are a few more places in the tests where
Would you mind adding it there too? |
No problem. |
9ed5183
to
a68d268
Compare
The second (with "-F" is the file to update. |
BEGINRELEASENOTES
*Framework
CHANGE: ComponentInstaller uses --cfg
*Tests
CHANGE: uses --cfg
ENDRELEASENOTES