Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v7r1] ComponentInstaller uses --cfg #4690

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Jul 20, 2020

BEGINRELEASENOTES

*Framework
CHANGE: ComponentInstaller uses --cfg
*Tests
CHANGE: uses --cfg

ENDRELEASENOTES

environment.yml Outdated Show resolved Hide resolved
@chaen chaen force-pushed the rel-v7r1_FIX_cfgArg branch from a066679 to dc7379c Compare July 21, 2020 11:41
@chaen
Copy link
Contributor Author

chaen commented Jul 23, 2020

Unfortunately, there is no possibility at the moment to have a job allowed to fail, while having the green arrow for the tests. So I propose to split this PR, and we will merge the CI part once this is resolved actions/runner#2347

@chaen chaen force-pushed the rel-v7r1_FIX_cfgArg branch from e18495e to 9ed5183 Compare July 28, 2020 09:44
@chaen
Copy link
Contributor Author

chaen commented Jul 28, 2020

@chrisburr any idea why all the PRs have issues starting all the tests lately ? Do we reach a quota or something ?

@chrisburr
Copy link
Member

There isn't a quota for public projects.

I think it's just instability on the GitHub side with an API call getting lost somewhere. The uptime shown on their status page isn't great and has been getting worse over the last few months. I've opened a support ticket about it.

@chaen
Copy link
Contributor Author

chaen commented Jul 28, 2020

Yeah I did check the status page but since it was green for the days we had issues, I assumed it was something else...

@chrisburr
Copy link
Member

I got an impressively quick response:

Ahh sorry about that -- this was a recent issue that our engineers just shipped a fix for a few hours ago. The symptoms match the runs you shared where the run reports as completed (in the UI under the Actions tab and in the API), but it has jobs reporting as queued.
I see the most recent example you shared is from ~15 hours ago, so before the fix went out. Can you let us know if you see any new runs that demonstrate this behavior?

And indeed, the actions overview shows the run as completed even if the detailed page doesn't. If anyone sees it happen again let me know and I'll continue the thread.

@fstagni
Copy link
Contributor

fstagni commented Jul 29, 2020

The comment in the op should be adapted. Anyway the main question is: do you still need to add something?

@chaen chaen changed the title [WIP][v7r1] ComponentInstaller uses --cfg [v7r1] ComponentInstaller uses --cfg Aug 4, 2020
@chaen
Copy link
Contributor Author

chaen commented Aug 5, 2020

Ready to go

@fstagni
Copy link
Contributor

fstagni commented Aug 5, 2020

There are a few more places in the tests where --cfg can be added, e.g.:

Would you mind adding it there too?

@chaen
Copy link
Contributor Author

chaen commented Aug 5, 2020

No problem.
For https://github.com/DIRACGrid/DIRAC/blob/integration/tests/Jenkins/utilities.sh#L401 it's a bit strange though that the configuration file is is passed twice

@chaen chaen force-pushed the rel-v7r1_FIX_cfgArg branch from 9ed5183 to a68d268 Compare August 5, 2020 12:16
@fstagni
Copy link
Contributor

fstagni commented Aug 5, 2020

No problem.
For https://github.com/DIRACGrid/DIRAC/blob/integration/tests/Jenkins/utilities.sh#L401 it's a bit strange though that the configuration file is is passed twice

The second (with "-F" is the file to update.

@atsareg atsareg merged commit 7eadc22 into DIRACGrid:rel-v7r1 Aug 6, 2020
@chaen chaen deleted the rel-v7r1_FIX_cfgArg branch August 11, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants