Feature/add starling via #173
Conversation
|
This one needs custom work for file dialogs. |
|
Yes, there are indeed some kind of sequencing patterns and note scales in binary format. |
falkTX
force-pushed
the
main
branch
4 times, most recently
from
e3644fb to
ae04997
Compare
falkTX
force-pushed
the
main
branch
5 times, most recently
from
f8e7b03 to
24bed60
Compare
falkTX
force-pushed
the
main
branch
3 times, most recently
from
54b0ec1 to
d3b722e
Compare
falkTX
force-pushed
the
main
branch
4 times, most recently
from
a30e278 to
f7a919f
Compare
dromer
force-pushed
the
feature/add-starling-via
branch
from
4a8c7ec to
91d1bd8
Compare
dromer
force-pushed
the
feature/add-starling-via
branch
from
2a9c484 to
4a1e3f8
Compare
dromer
force-pushed
the
feature/add-starling-via
branch
from
503ad65 to
d42d1b5
Compare
|
This should be ready, but can be finalized post 23.10 release. |
falkTX
force-pushed
the
main
branch
8 times, most recently
from
0cba0a1 to
80bda51
Compare
| if (spl.ok()) | ||
| { | ||
| #define modelScanner modelStarlingViaScanner | ||
| #define Scale starlingViaScale |
There was a problem hiding this comment.
the scale and wavetable macros are not needed here, not sure about it being needed on this file at all tbh
There was a problem hiding this comment.
hmm, pretty sure I had conflicts when not defining these. can try again without
There was a problem hiding this comment.
Hmm, commented these out, rebuilt the StarlingVia components and it nearly builds.
Only at ttl generation do I now get what(): Manifest contains module SCANNER but it is not defined in plugin
|
There are quite some issues regarding unitialized values, as can be seen by the CI test failure Also 2 extra "Mismatched free() / delete / delete []" We need to fix those before merging. |
moar.
Really neat sequencing/logic/trigger modules. with fancy dark panels!
Based on the Via line of eurorack modules